This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
klient/os: add exec/kill methods #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeczalik
force-pushed
the
os-exec-kill
branch
3 times, most recently
from
d134628
to
4cbd9d7
Compare
rjeczalik
force-pushed
the
os-exec-kill
branch
2 times, most recently
from
32bb89a
to
a32bccd
Compare
This PR adds the following kite methods: - os.exec - os.kill The os.exec methods is a reworked version of existing exec method with a new API that is needed for KD. Since the exec method is still used on client side, it's being marked as deprecated and new version rolled out. The os.kill method addresses shortcoming in current "kd run" implementation - if user aborts command execution with CTRL+C, the command won't get killed on a remote machine. New implementation is going to call machine.kill upon exit, which effectively will kill the user process on the remote side. The os.kill method is limited to only those processes that were started with os.exec.
ppknap
approved these changes
Mar 10, 2017
|
|
||
| // TestCommandHelper is used by TestExec / TestKill tests to | ||
| // execute test code as an external process. | ||
| func TestCommandHelper(t *testing.T) { |
|
@cihangir Ptal, I'm going to address your comments if you have any in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps: #10726
This PR adds the following kite methods:
The os.exec methods is a reworked version of existing
exec method with a new API that is needed for KD. Since
the exec method is still used on client side, it's being
marked as deprecated and new version rolled out.
The os.kill method addresses shortcoming in current "kd run"
implementation - if user aborts command execution with CTRL+C,
the command won't get killed on a remote machine.
New implementation is going to call machine.kill upon exit,
which effectively will kill the user process on the remote side.
The os.kill method is limited to only those processes that
were started with os.exec.