vagrantutil: fix parseRecords for vagrant 1.8+ #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if data != "" { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
Can be simplified too:
if typeName == record[2] && record[3] != "" {
data = record[3]
break
}
| // startCommand starts the command and sends back both the stdout and stderr to | ||
| // the returned channel. Any error happened during the streaming is passed to | ||
| // the Error field. | ||
| func startCommand(cmd *exec.Cmd) (<-chan *CommandOutput, error) { | ||
| func (v *Vagrant) startCommand(cmd *exec.Cmd) (<-chan *CommandOutput, error) { |
There was a problem hiding this comment.
Same for this, no need to make it a method of *Vagrant. It would make it easier to implement tests
There was a problem hiding this comment.
I'd need to add another argument for logging the command's ouput - startCommand(cmd *exec.Cmd, log fn(string)) - is it worth it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @fatih @sent-hil