fix(issue-7): missing validation for tag path (#8)

Solve issue #7
kodingdotninja · Nov 16, 2021 · 458ebf3 · 458ebf3
1 parent 3d13ee6
commit 458ebf3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/examples/Issue7.js b/examples/Issue7.js
diff --git a/examples/issue7.svg b/examples/issue7.svg
diff --git a/lib/chakra.js b/lib/chakra.js
@@ -26,8 +26,18 @@ const createChakraIcon = (...sources) => {
   const isTypescript = sources.some(({ isTypescript }) => isTypescript);
   const perFileCode = ({ source: svg, displayName }) => {
     const hast = SvgParser.parse(svg);
-
-    if (ast.hastChildrenLength(hast) > 1) {
+    // This for solve issue {https://github.com/kodingdotninja/create-chakra-icons/issues/7}
+    // In the issue 7, have some example svg file at examples/issue7.svg
+    // {isNotPathTagName} for know the tag is not <path />
+    // when not a <path />, so make as icon component  (not functional component)
+    const isNotTagnamePath = (() => {
+      if (hast.children[0].children) {
+        const [head] = hast.children[0].children;
+        return head.tagName && head.tagName !== "path";
+      }
+      return false;
+    })();
+    if (ast.hastChildrenLength(hast) > 1 || isNotTagnamePath) {
       return ast.hastToComponent(hast, { displayName, isTypescript });
     }