Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Android Phone - Google Chrome browser #67

Closed
riteshpuj2013 opened this issue Dec 16, 2015 · 28 comments
Closed

Doesn't work on Android Phone - Google Chrome browser #67

riteshpuj2013 opened this issue Dec 16, 2015 · 28 comments

Comments

@riteshpuj2013
Copy link

Hi Phanan,

I finally got it working. It works on and desktop as well phone. But on phone, it works only on firefox but not on chrome.

P.S: Phone is One plus one using Android L 5.1.1

Let me know if you need more details.

Thanks
Ritesh

@riteshpuj2013 riteshpuj2013 changed the title Doesn't work on chrome Doesn't work on Android Phone - Google Chrome browser Dec 16, 2015
@Thom-x
Copy link

Thom-x commented Dec 16, 2015

Music is also not loading on Android M 6.0.1 (no error in console).

@itinerant-fox
Copy link

Tried on Note 4 - Android version 5.0.1 Stock - Chrome browser .
Page loaded fine. Music streaming didn't work in Mobile Chrome Browser.
Everything working fine in Mobile firefox.

@MarceauKa
Copy link

Galaxy Alpha - Android 5.0.2 - Chrome and Native browser.
All is fine on my local network.

@riteshpuj2013
Copy link
Author

My google chrome version is 47.0.2526.83

I hope it helps to debug the issue further.

@etopian
Copy link

etopian commented Dec 16, 2015

we should not be using the ♫ character for the path. that seems to break chrome's paths. it's cute, but unnecessary.

@phanan
Copy link
Member

phanan commented Dec 17, 2015

we should not be using the ♫ character for the path. that seems to break chrome's paths. it's cute, but unnecessary.

That character doesn't have anything to do with song playback. Every browser I know supports utf-8 URLs anyway.

@etopian
Copy link

etopian commented Dec 17, 2015

Perhaps I have a problem with the nginx configuration. for me the page did not load on chrome on android.

@etopian
Copy link

etopian commented Dec 17, 2015

The URL gets escaped in Chrome on Android, this is on purpose by Chrome, this is Chrome 44. And that results in NotFoundHttpException. Changing that route to the URL 'm' works for me.

@phanan
Copy link
Member

phanan commented Dec 17, 2015

I'd suggest checking your nginx conf then.

@phanan phanan closed this as completed Dec 17, 2015
@phanan phanan reopened this Dec 17, 2015
@kevincaradant
Copy link

@etopian , what is your configuration to work on your mobile phone or even a device other that the server itself ? localhost:8080 on server OK that work. but on my computer or smartphone , i can't have KOEL even by IP on the URL :( .

I tried apache but i failed and i wish to try with nginx but everytime that said me "error 404" or "forbidden 403" but i don't think it's a problem of rights... if you can explain me step by step , it should be very nice from you.

I just put all files of koel in /var/www/koel/html. And try to follow this tuto unsuccessfully :/ : https://www.digitalocean.com/community/tutorials/how-to-set-up-nginx-server-blocks-virtual-hosts-on-ubuntu-14-04-lts.

So this is my state :

capturenginx
capturenginx2

Thank you in advance :)

@etopian
Copy link

etopian commented Dec 17, 2015

@kevincaradant i use my docker image.. https://github.com/etopian/docker-koel

@kevincaradant
Copy link

Ah oki nice , i'm going to try ! :).

@MyIgel
Copy link

MyIgel commented Dec 19, 2015

I have debugged it on my android phone (5.1.1, cm12.1) with the latest Chrome Beta:

Uncaught TypeError: Failed to construct 'Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification() instead.
t.default.play @ main-56b549c9de.js:14
(anonymous function) @ main-56b549c9de.js:14
e @ main-56b549c9de.js:7

the related Code is

[...] n=new Notification("♫ "+e.title,{icon:e.album.cover,body:e.album.name+" – "+e.album.artist.name}); [...]

in resources/assets/js/services/playback.js:97

the Notification() has been removed from Chrome on Android, see here

@phanan
Copy link
Member

phanan commented Dec 20, 2015

Damn! More work for us, thanks Chrome team!

phanan pushed a commit that referenced this issue Dec 20, 2015
@phanan phanan closed this as completed Dec 20, 2015
@lazyhummingbird
Copy link

I saw this bugfix (wow you're fast!), but how do I implement it now that I've replaced the file? Do I have to reinstall koel entirely or is there a way I can just update it?

@phanan
Copy link
Member

phanan commented Dec 20, 2015

Just git pull and then gulp --production ;)

On Sun, Dec 20, 2015 at 3:36 PM, lazyhummingbird notifications@github.com
wrote:

I saw this bugfix (wow you're fast!), but how do I implement it now that
I've replaced the file? Do I have to reinstall koel entirely or is there a
way I can just update it?


Reply to this email directly or view it on GitHub
#67 (comment).

@lazyhummingbird
Copy link

I double checked that playback.js was up to date and did 'gulp --production' but I'm still having the same error :/

Sorry to resurrect this bug. This whole project is great work and I can't wait until it works on my mobile device.

@pelletiermaxime
Copy link

Just tried on Android and had no sound in Chrome/Opera. Works fine in Firefox.

@phanan
Copy link
Member

phanan commented Dec 21, 2015

Now to think about it, that audio isn't being played shouldn't have anything to do with notifications. The play() method is executed before notification happens.

@phanan
Copy link
Member

phanan commented Dec 21, 2015

Sadly I don't have an Android to test.

@Dogfalo
Copy link
Contributor

Dogfalo commented Dec 21, 2015

@phanan, I was also having problems on my Android Chrome. Maybe if I have time tomorrow I will take a look

@Dogfalo
Copy link
Contributor

Dogfalo commented Dec 28, 2015

@phanan,
I took a very brief look last week, there were no console errors. I think the problem may be related to this:

http://stackoverflow.com/questions/31843020/using-htaccess-authentication-breaks-html-audio-elements-in-chrome-android
Chromium bug tracker: https://code.google.com/p/chromium/issues/detail?id=331876

@phanan
Copy link
Member

phanan commented Dec 29, 2015

Well, except Koel doesn't use htaccess basic auth...

On Tue, Dec 29, 2015 at 7:28 AM, Alvin Wang notifications@github.com
wrote:

@phanan https://github.com/phanan,
I took a very brief look last week, there were no console errors. I think
the problem may be related to this:

http://stackoverflow.com/questions/31843020/using-htaccess-authentication-breaks-html-audio-elements-in-chrome-android


Reply to this email directly or view it on GitHub
#67 (comment).

@Dogfalo
Copy link
Contributor

Dogfalo commented Dec 29, 2015

ok I did more digging. It is a bug related to chrome and Partial Content (206). I tried commenting that out and it worked in chrome on android. But it essentially removes the "streaming" aspect as it needs to download the song first before playing.. Not really sure how this can be fixed if it is a problem with chrome

@phanan
Copy link
Member

phanan commented Dec 29, 2015

Thanks. If it's Chrome then I guess it will be fixed in no time. I have
high trust in the team.

On Tue, Dec 29, 2015 at 3:28 PM, Alvin Wang notifications@github.com
wrote:

ok I did more digging. It is a bug related to chrome and Partial Content
(206). I tried commenting that out and it worked in chrome on android. But
it essentially removes the "streaming" aspect as it needs to download the
song first before playing.. Not really sure how this can be fixed if it is
a problem with chrome


Reply to this email directly or view it on GitHub
#67 (comment).

@Isaiahjm
Copy link

@Dogfalo May I ask how you went about commenting out the cause of the issue? This bug in Chrome has prevented me from using koel since the first release. It just sits idle on my server. Would be great if we could add the temporary work around in the wiki as well for those thinking about using koel.

@lazyhummingbird
Copy link

@Dogfalo @phanan any chance that either of you can detail the fix?

@AtomicVar
Copy link

Still cannot play on Chrome for Android 69...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests