Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable usage with S3-compatible services #1381

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

sergiustheblack
Copy link
Contributor

This safely allows Koel to use songs hosted on non-AWS s3 storage. However, default behaviour is unchanged.

@phanan
Copy link
Member

phanan commented Dec 6, 2021

Thanks! Can you point me to the documentation of this feature and the default value?

@sergiustheblack
Copy link
Contributor Author

it was a challenge to find default value. so I checked sources and default s3cmd config
https://github.com/aws/aws-sdk-php/blob/ff4872f72fac84ce6e384c4f40d30ec7b0d1eeda/src/S3/S3UriParser.php
however I didn't test it myself with AWS. I use another s3 provider.
docs on setting custom endpoint is here
https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#endpoint
and
https://docs.aws.amazon.com/general/latest/gr/rande.html

@phanan phanan changed the title Flexible s3 config: possibility to use with non-AWS object storage feat: enable usage with S3-compatible services Dec 22, 2021
@phanan phanan merged commit 3872482 into koel:master Dec 22, 2021
@phanan
Copy link
Member

phanan commented Dec 22, 2021

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants