New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: persist lyrics zoom level #1556

Merged

phanan merged 1 commit into master from feat/save-zoom-lvl

Oct 26, 2022

Member

phanan commented Oct 26, 2022

No description provided.

what-the-diff bot commented Oct 26, 2022 •

edited

Added a new preference for lyrics zoom level
Set the default value of this preference to 1 (100%)
Updated LyricsPane component to use this setting instead of hardcoding it at 100%
Snapshot test was updated because we now set font size in rems, not ems anymore and also added style attribute with computed font-size property based on user's preferences


          feat: persist lyrics zoom level

2d753ea

phanan force-pushed the feat/save-zoom-lvl branch from a04d542 to 2d753ea Compare

October 26, 2022 19:14

phanan merged commit 65d5a54 into master

phanan deleted the feat/save-zoom-lvl branch

October 26, 2022 19:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment