Skip to content

Commit

Permalink
fix: data type for playlist ID
Browse files Browse the repository at this point in the history
  • Loading branch information
phanan committed Apr 20, 2024
1 parent 22f2fbd commit 577a8c5
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 21 deletions.
10 changes: 0 additions & 10 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,11 @@ PODS:
- FMDB/standard (2.7.5)
- just_audio (0.0.1):
- Flutter
- MTBBarcodeScanner (5.0.11)
- native_qr (0.0.1):
- Flutter
- path_provider_foundation (0.0.1):
- Flutter
- FlutterMacOS
- qr_code_scanner (0.2.0):
- Flutter
- MTBBarcodeScanner
- ReachabilitySwift (5.0.0)
- sqflite (0.0.2):
- Flutter
Expand All @@ -34,13 +30,11 @@ DEPENDENCIES:
- just_audio (from `.symlinks/plugins/just_audio/ios`)
- native_qr (from `.symlinks/plugins/native_qr/ios`)
- path_provider_foundation (from `.symlinks/plugins/path_provider_foundation/darwin`)
- qr_code_scanner (from `.symlinks/plugins/qr_code_scanner/ios`)
- sqflite (from `.symlinks/plugins/sqflite/ios`)

SPEC REPOS:
trunk:
- FMDB
- MTBBarcodeScanner
- ReachabilitySwift

EXTERNAL SOURCES:
Expand All @@ -58,8 +52,6 @@ EXTERNAL SOURCES:
:path: ".symlinks/plugins/native_qr/ios"
path_provider_foundation:
:path: ".symlinks/plugins/path_provider_foundation/darwin"
qr_code_scanner:
:path: ".symlinks/plugins/qr_code_scanner/ios"
sqflite:
:path: ".symlinks/plugins/sqflite/ios"

Expand All @@ -70,10 +62,8 @@ SPEC CHECKSUMS:
Flutter: e0871f40cf51350855a761d2e70bf5af5b9b5de7
FMDB: 2ce00b547f966261cd18927a3ddb07cb6f3db82a
just_audio: baa7252489dbcf47a4c7cc9ca663e9661c99aafa
MTBBarcodeScanner: f453b33c4b7dfe545d8c6484ed744d55671788cb
native_qr: 2a3151f33e6c69d4320fc5c5f24848200c1aa4fa
path_provider_foundation: c68054786f1b4f3343858c1e1d0caaded73f0be9
qr_code_scanner: bb67d64904c3b9658ada8c402e8b4d406d5d796e
ReachabilitySwift: 985039c6f7b23a1da463388634119492ff86c825
sqflite: 6d358c025f5b867b29ed92fc697fd34924e11904

Expand Down
6 changes: 3 additions & 3 deletions lib/models/playlist.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'package:app/models/models.dart';
import 'package:faker/faker.dart';

class Playlist {
dynamic id; // This might be a UUID string in the near future
var id; // This might be a UUID string in the near future
String name;
bool isSmart;
List<Song> songs = [];
Expand All @@ -21,11 +21,11 @@ class Playlist {
);
}

factory Playlist.fake({dynamic id, String? name, bool? isSmart}) {
factory Playlist.fake({var id, String? name, bool? isSmart}) {
Faker faker = Faker();

return Playlist(
id: id ?? faker.randomGenerator.integer(100, min: 1),
id: id ?? faker.guid.guid(),
name: name ?? faker.food.cuisine(),
isSmart: isSmart ?? false,
);
Expand Down
2 changes: 1 addition & 1 deletion lib/providers/song_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class SongProvider with ChangeNotifier, StreamSubscriber {
}

Future<List<Song>> fetchForPlaylist(
int playlistId, {
var playlistId, {
bool forceRefresh = false,
}) async {
if (forceRefresh) AppState.delete(['playlist.songs', playlistId]);
Expand Down
1 change: 0 additions & 1 deletion lib/ui/screens/login.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import 'package:app/utils/preferences.dart' as preferences;
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_spinkit/flutter_spinkit.dart';
import 'package:native_qr/native_qr.dart';
import 'package:provider/provider.dart';

class LoginScreen extends StatefulWidget {
Expand Down
1 change: 0 additions & 1 deletion lib/ui/screens/now_playing.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'dart:ui';

import 'package:app/enums.dart';
import 'package:app/main.dart';
import 'package:app/mixins/stream_subscriber.dart';
import 'package:app/models/models.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/screens/playlist_details.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class _PlaylistDetailsScreen extends State<PlaylistDetailsScreen> {
}

Future<List<Song>> buildRequest(
int playlistId, {
var playlistId, {
bool forceRefresh = false,
}) {
return context
Expand Down
1 change: 0 additions & 1 deletion lib/ui/widgets/artist_card.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:app/enums.dart';
import 'package:app/models/models.dart';
import 'package:app/router.dart';
import 'package:app/ui/widgets/widgets.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/ui/widgets/song_card.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:app/enums.dart';
import 'package:app/main.dart';
import 'package:app/models/models.dart';
import 'package:app/router.dart';
Expand Down
2 changes: 0 additions & 2 deletions test/ui/widgets/playlist_row_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/annotations.dart';
import 'package:mockito/mockito.dart';
import 'package:provider/provider.dart';
import 'package:rxdart/rxdart.dart';

import '../../extensions/widget_tester_extension.dart';
import 'playlist_row_test.mocks.dart';
Expand Down

0 comments on commit 577a8c5

Please sign in to comment.