Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: F-Droid Release #70

Closed
3lpsy opened this issue May 20, 2022 · 18 comments
Closed

Feature Request: F-Droid Release #70

3lpsy opened this issue May 20, 2022 · 18 comments

Comments

@3lpsy
Copy link

3lpsy commented May 20, 2022

I kindly request an f-droid release. I feel that an f-droid release would not only attract more koel users, but also make it easier for users to install koel on devices without the google play store (LineageOS). I recognize getting an app on f-droid isn't as simple as uploading it to their store (Inclusion Policy) and this is "nice to have".

If you are interested, please check the Quick Start Guide. Thanks!

@pabloscloud
Copy link

Yes, please! 💙

@phanan
Copy link
Member

phanan commented Apr 9, 2023

I'll be bluntly honest here: I don't even know what F-Droid is, and the process looks much more complicated than I'm willing to handle (or have the time to). If you want to own this, I'm happy to help.

@pabloscloud
Copy link

@phanan bruh

@3lpsy
Copy link
Author

3lpsy commented May 5, 2023

@phanan Totally fair. F-Droid is probably the most popular alternative app store for android. All software on it is open source and the builds are generated by the F-droid team. If you run LineageOS, the most popular android alternative, you typically get most if not all your apps from F-droid. Unfortunately, I don't have much experience getting an app on F-droid but if I ever acquire the skills/knowledge necessary, I'll circle back and try to PR something. Thanks for taking a look :)

bibo38 added a commit to bibo38/player that referenced this issue Jun 3, 2023
- Added the required Flutter version (3.7.12) as a submodule
- Updated Gradle version to match the minimum required version
- Added F-Droid metadata files, copied mostly from the Play store page

Related to koel#70
bibo38 added a commit to bibo38/player that referenced this issue Jun 3, 2023
- Added the required Flutter version (3.7.12) as a submodule
- Updated Gradle version to match the minimum required version
- Added F-Droid metadata files, copied mostly from the Play store page

Related to koel#70
@bibo38
Copy link
Contributor

bibo38 commented Jun 3, 2023

I've created a PR with the required additions for F-Droid (it's the recommended way to add them to the repository). Once it's merged, I'll create the Merge request for inclusion on the F-Droid side.

@phanan There are some minor tasks, that will be necessary for F-Droid:

  • Create a Git tag for every release (e.g. v2.0.2)
  • Update the .flutter submodule, if the code is updated to a newer Flutter version
  • And a nice to have: add a corresponding changelog file for every release (numbering is 4000 + versionCode, see the example in the PR)

@phanan
Copy link
Member

phanan commented Jun 5, 2023

@bibo38 Thanks a lot! I've merged #87. Let me know if there's anything else I can help with.

@bibo38
Copy link
Contributor

bibo38 commented Jun 6, 2023

@phanan Nice, thanks. The fdroid checkupdates call currently outputs an error, as the last tag references an older version. Could you tag the current HEAD commit with v2.0.2?

@phanan
Copy link
Member

phanan commented Jun 6, 2023

@bibo38 Done!

@bibo38
Copy link
Contributor

bibo38 commented Jun 6, 2023

Inclusion Merge Request on the F-Droid side: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13208

@bilogic
Copy link

bilogic commented Jul 2, 2023

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

@pabloscloud
Copy link

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

Same, I tried installing it via Obtainium and that didn't work either. And in Android Studio I just got a bunch of errors probably due to incompatible dependencies.

@bibo38
Copy link
Contributor

bibo38 commented Jul 5, 2023

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

The apks are unsigned. You can only install signed apps on an Android device, see https://stackoverflow.com/questions/10930331/how-to-sign-an-already-compiled-apk

You probably want the 2019 version, as it's for ARM64 v8a, while 1019 is for ARM v7a and 4019 is for x64

@bibo38
Copy link
Contributor

bibo38 commented Aug 9, 2023

@phanan Got some comments from a review on the F-Droid side. I've implemented these in #89 . Could you merge this and either force update the v2.0.2 tag or change the version to 2.0.3 and tag it with v2.0.3?

@bibo38
Copy link
Contributor

bibo38 commented Aug 20, 2023

@phanan Thanks for merging, but the new tag version doesn't match the version in the apk (which should come from the pubspec.yaml) and F-Droid currently fails on this. Sorry for me not to mention this change that explicitly (the "change the version to 2.0.3" part). So maybe update it to 2.0.4 and tag it again or force update the 2.0.2 tag as it's currently F-Droid specific anyway.

@phanan phanan closed this as completed in c9a4383 Aug 20, 2023
@bibo38
Copy link
Contributor

bibo38 commented Aug 25, 2023

Current state: By requet (c9a4383#r124979603), I've created a fork for the F-Droid build.

You can find it here: https://codeberg.org/bibo38/koelplayer

Be aware, that until this is merged into F-Droid, this is subjected to changes! I'm trying to set up reproducible builds, but currently failing.

@bilogic
Copy link

bilogic commented Aug 26, 2023

thanks @bibo38, but I don't get it, if this issue is closed, does it mean F-droid side is ok? I still can't find koel in F-droid.

@bibo38
Copy link
Contributor

bibo38 commented Oct 9, 2023

The issue was closed due to the commit message of @phanan , although it was just an improvement to try making the F-Droid build work: c9a4383

After setting up my fork, I was hinted that a fork would require me to change the App ID, Name (in all texts/translations) and Logo due to F-Droids Inclusion Policy.

This is currently too much of a burden for me to get this app included (and keep it updated). Therefore I'll stop working on the F-Droid inclusion of Koel.

@bilogic
Copy link

bilogic commented Oct 11, 2023

thanks, then i think it's time i moved onto something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants