Not preloading Gradients

koenbok · Oct 2, 2017 · 2a91ec1 · 2a91ec1
1 parent f057af6
commit 2a91ec1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/framer/Extras/Preloader.coffee b/framer/Extras/Preloader.coffee
@@ -43,6 +43,7 @@ class Preloader extends BaseClass
 		_.map(context.layers, "player").map(@addPlayer)
 
 	addImage: (image) =>
+		return if image instanceof Gradient
 		if image and image not in @_media
 			@_media.push(image)
 			# We simply count failed images as loaded for now so that we avoid

diff --git a/test/tests.coffee b/test/tests.coffee
@@ -54,5 +54,6 @@ require "./tests/DeviceComponentTest"
 require "./tests/SliderComponentTest"
 require "./tests/RangeSliderComponentTest"
 require "./tests/FlowComponentTest"
+require "./tests/PreloaderTest"
 
 mocha.run()
diff --git a/test/tests/PreloaderTest.coffee b/test/tests/PreloaderTest.coffee
@@ -0,0 +1,10 @@
+describe "Preloader", ->
+	it "should not preload gradients", ->
+		Framer.CurrentContext = new Framer.Context(name: "test")
+		Framer.CurrentContext.run ->
+			new Layer
+				gradient:
+					start: "red"
+		Framer.Extras.Preloader.enable()
+		Framer.Preloader.addImagesFromContext(Framer.CurrentContext)
+		Framer.Preloader._media.length.should.equal 0