Fix animation rounding issue

https://www.facebook.com/groups/framerjs/permalink/571261036334305/
koenbok · Oct 5, 2014 · fbde7a8 · fbde7a8
1 parent 2a0439a
commit fbde7a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/framer/Animators/BezierCurveAnimator.coffee b/framer/Animators/BezierCurveAnimator.coffee
@@ -29,6 +29,9 @@ class exports.BezierCurveAnimator extends Animator
 		@options = Utils.setDefaultProperties options,
 			values: BezierCurveDefaults["ease-in-out"]
 			time: 1
+			precision: 1/1000
+
+		console.log "values", @options.values
 
 		@_unitBezier = new UnitBezier \
 			@options.values[0],
@@ -49,7 +52,7 @@ class exports.BezierCurveAnimator extends Animator
 		@_unitBezier.solve @_time / @options.time
 
 	finished: ->
-		@_time >= @options.time
+		@_time >= @options.time - @options.precision
 
 
 # WebKit implementation found on http://stackoverflow.com/a/11697909

diff --git a/framer/Animators/LinearAnimator.coffee b/framer/Animators/LinearAnimator.coffee
@@ -8,6 +8,7 @@ class exports.LinearAnimator extends Animator
 
 		@options = Utils.setDefaultProperties options,
 			time: 1
+			precision: 1/1000
 
 		@_time = 0
 
@@ -20,4 +21,4 @@ class exports.LinearAnimator extends Animator
 		@_time / @options.time
 
 	finished: ->
-		@_time >= @options.time
+		@_time >= @options.time - @options.precision