Prevent rounding bug in LayerDraggable #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A colleague recently discovered a bug that caused draggable layers with constraints to incorrectly animate to a slightly different position that specified. The bug can be reproduced using the following code: https://gist.github.com/daneden/f5a0826168ea9626af3091d5b08c7911 Dragging the layer `myCard` up causes it to return to position `y: 89` instead of `y: 90`. This PR addresses the issue by using `Math.round` instead of `parseInt` to ensure the layer is returned to the correct constraint. ```js > parseInt(8.999) 9 > Math.round(8.999) 8 ```
|
cc @koenbok |
|
Makes sense to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colleague recently discovered a bug that caused draggable layers with constraints to incorrectly animate to a slightly different position than specified. The bug can be reproduced using the following code: https://gist.github.com/daneden/f5a0826168ea9626af3091d5b08c7911
Dragging the layer
myCardup causes it to return to positiony: 89instead ofy: 90. This PR addresses the issue by usingMath.roundinstead ofparseIntto ensure the layer is returned to the correct constraint.