Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling None in UriMap #27

Closed
koenedaele opened this issue Jul 27, 2016 · 0 comments
Closed

Handling None in UriMap #27

koenedaele opened this issue Jul 27, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@koenedaele
Copy link
Member

When adding providers to the registry, we create a mapping between conceptscheme.uri and provider.ID. Sometimes conceptscheme.uri is None, which create a mapping between None and a certain provider. When calling registry.get_provider(None), this provider is returned. This is unwanted behaviour since this makes it possible to register more than one provider with None. Leading to unexpected results.

Also, it might be better to check that we aren't registering more than one provider with the same URI anyway.

Reported by @BartSaelen

@koenedaele koenedaele added the bug label Jul 27, 2016
@koenedaele koenedaele added this to the 0.6.0 milestone Jul 27, 2016
@koenedaele koenedaele self-assigned this Jul 27, 2016
koenedaele added a commit that referenced this issue Jul 27, 2016
koenedaele added a commit that referenced this issue Jul 27, 2016
Handle cases where a URI is invalid or None. Should give more feedback where
possible now.
koenedaele added a commit that referenced this issue Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant