Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
koenighotze committed Apr 18, 2024
1 parent c013c56 commit d793c5d
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
12 changes: 6 additions & 6 deletions getting-started/07/bucket.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ resource "google_storage_bucket" "websitecontent" {
}
}

resource "google_storage_bucket_iam_member" "member" {
count = var.debug
bucket = google_storage_bucket.websitecontent.name
role = "roles/storage.admin"
member = "user:${var.local_user_email}"
}
# resource "google_storage_bucket_iam_member" "member" {
# count = var.debug
# bucket = google_storage_bucket.websitecontent.name
# role = "roles/storage.admin"
# member = "user:${var.local_user_email}"
# }

data "google_iam_policy" "bucket_iam_policy" {
binding {
Expand Down
34 changes: 17 additions & 17 deletions getting-started/07/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,31 +29,31 @@ variable "sa_email" {
}
}

variable "debug" {
type = number
default = 0
description = "Set to 1 to enable debug resources"
# variable "debug" {
# type = number
# default = 0
# description = "Set to 1 to enable debug resources"

validation {
condition = var.debug == 0 || var.debug == 1
error_message = "Debug must be zero or one."
}
}
# validation {
# condition = var.debug == 0 || var.debug == 1
# error_message = "Debug must be zero or one."
# }
# }

variable "rebuild_mig" {
type = bool
default = false
}

variable "local_user_email" {
type = string
default = "only@for.debugging"
# variable "local_user_email" {
# type = string
# default = "only@for.debugging"

validation {
condition = length(var.local_user_email) > 0 && can(regex("[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}", var.local_user_email))
error_message = "Invalid service account email format. Please provide a valid email address."
}
}
# validation {
# condition = length(var.local_user_email) > 0 && can(regex("[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}", var.local_user_email))
# error_message = "Invalid service account email format. Please provide a valid email address."
# }
# }

# variable "number_of_backend_services_size" {
# type = number
Expand Down

0 comments on commit d793c5d

Please sign in to comment.