Skip to content

Commit

Permalink
drm/i915/display: remove debug message from error path
Browse files Browse the repository at this point in the history
First check in the function is if swsci() is supported. All the error
paths are easy to figure out the reason, so remove the extra debug
message: it's normal not to support swsci() e.g. in dgfx.

v2: Rather than special case dgfx, just remove the debug message
    (from Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201027044618.719064-2-lucas.demarchi@intel.com
  • Loading branch information
lucasdemarchi committed Oct 28, 2020
1 parent 949ab9d commit 859d74f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/gpu/drm/i915/display/intel_opregion.c
Original file line number Diff line number Diff line change
Expand Up @@ -1007,12 +1007,8 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
int ret;

ret = swsci(dev_priv, SWSCI_GBDA_PANEL_DETAILS, 0x0, &panel_details);
if (ret) {
drm_dbg_kms(&dev_priv->drm,
"Failed to get panel details from OpRegion (%d)\n",
ret);
if (ret)
return ret;
}

ret = (panel_details >> 8) & 0xff;
if (ret > 0x10) {
Expand Down

0 comments on commit 859d74f

Please sign in to comment.