Skip to content

Commit

Permalink
net/vxlan: Go over all candidate streams for GRO matching
Browse files Browse the repository at this point in the history
The loop in vxlan_gro_receive() over the current set of candidates for
coalescing was wrongly aborted once a match was found. In rare cases,
this can cause a false-positives matching in the next layer GRO checks.

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
ogerlitz authored and davem330 committed Jan 31, 2014
1 parent b5aaab1 commit 920a0fd
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/vxlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -596,10 +596,8 @@ static struct sk_buff **vxlan_gro_receive(struct sk_buff **head, struct sk_buff
NAPI_GRO_CB(p)->same_flow = 0;
continue;
}
goto found;
}

found:
type = eh->h_proto;

rcu_read_lock();
Expand Down

0 comments on commit 920a0fd

Please sign in to comment.