Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notifications #26

Closed
contentkraft opened this issue Aug 20, 2020 · 6 comments
Closed

Improve notifications #26

contentkraft opened this issue Aug 20, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@contentkraft
Copy link

contentkraft commented Aug 20, 2020

I noticed that Slack notifications work okay, but if I get a message in a certain channel and click on it, it doesn’t open the channel, just the Slack window.

Another thing I can’t get to work are notifications in the app icons. I never know how many unread messages there are in Slack, Google Mail, etc.

Is this something that could be added to the app icons?

@kofigumbs
Copy link
Owner

kofigumbs commented Aug 20, 2020

Yup, this makes sense. Right now the notifications hook is the bare minimum (haven't changed it since the MVP). I'm gonna drop the complete list of notifications improvements here for my future self. Also wanted to say thanks for creating the other two issues—#25 was a pretty easy fix, and it'll definitely be in the next release.

@makeavish
Copy link

@contentkraft I am not receiving banner notifications on slack.
How did you enable those?
I am on MacOS Catalina 10.15.6

@kofigumbs kofigumbs added the enhancement New feature or request label Dec 21, 2020
@toomim
Copy link

toomim commented Apr 17, 2021

Does anyone have an intuition for how difficult it would be to make badges work? I tend to use badges rather than popup notifications, because I think they are psychologically healthier. :)

Edit: Ah, looks like the API is as simple as:

NSApp.dockTile.badgeLabel = @"Badge";

@toomim
Copy link

toomim commented Apr 18, 2021

I'd be happy to fund the work in adding a badge icon for notifications count.

I want to write a chat app using multi, and it'd be great to see how many unread chat messages there are.

Ideally, the chat would be able to communicate with multi to tell it how many messages are unread. This number might be different than "the number of notifications that have arrived since last focusing the app", because the chat might have multiple channels, and the user might not have clicked on one of the channels to view the messages within it, even though he has focused the app.

@kofigumbs
Copy link
Owner

Thanks for the link to the badges example. If you're up for experimenting, I think it should be easy enough to get this working in a fork. The notification integration is in Browser+notification.swift.

I really appreciate your offer for funding. I'm not set up to have folks sponsor individual features, but if I ever get to that I'll let you know.

@kofigumbs kofigumbs mentioned this issue Apr 26, 2021
8 tasks
kofigumbs added a commit that referenced this issue Apr 26, 2021
kofigumbs added a commit that referenced this issue Apr 26, 2021
@kofigumbs
Copy link
Owner

This thread turned into a couple of requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants