openapi-request-validator: Added check for whether readOnly prop is i…

…n list of required fields before splicing out (fixes #717) (#719)

packages/openapi-request-validator/index.ts

@@ -642,7 +642,9 @@ function sanitizeReadonlyPropertiesFromRequired(
       .filter((i) => i !== undefined)
       .forEach((value) => {
         const index = schema.required.indexOf(value);
-        schema.required.splice(index, 1);
+        if (index !== -1) {
+          schema.required.splice(index, 1);
+        }
       });
   }
   return schema;

packages/openapi-request-validator/test/data-driven/fail-a-missing-required-body-property-with-read-only-property.js

@@ -0,0 +1,46 @@
+module.exports = {
+  validateArgs: {
+    properties: [],
+    requestBody: {
+      description: 'a test body',
+      content: {
+        'application/json': {
+          schema: {
+            $ref: '#/components/schemas/TestBody',
+          },
+        },
+      },
+    },
+    componentSchemas: {
+      TestBody: {
+        properties: {
+          foo: {
+            type: 'string',
+          },
+          bar: {
+            type: 'string',
+            readOnly: true,
+          },
+        },
+        required: ['foo'],
+      },
+    },
+  },
+  request: {
+    body: {},
+    headers: {
+      'content-type': 'application/json',
+    },
+  },
+  expectedError: {
+    status: 400,
+    errors: [
+      {
+        path: 'foo',
+        errorCode: 'required.openapi.requestValidation',
+        message: "should have required property 'foo'",
+        location: 'body',
+      },
+    ],
+  },
+};