Skip to content

Commit

Permalink
Reverts b30bf89
Browse files Browse the repository at this point in the history
Removed Request::check_cache(). The replacement method doesn't work, so it's better to change the api and remove the method instead of confusing people by leaving in a method that is broken. Refs #3743
  • Loading branch information
isaiahdw committed Feb 17, 2011
1 parent faa011e commit 82bbd09
Showing 1 changed file with 1 addition and 22 deletions.
23 changes: 1 addition & 22 deletions classes/kohana/request.php
Expand Up @@ -661,7 +661,7 @@ protected static function _parse_accept( & $header, array $accepts = NULL)
* created using the [Request::instance] or [Request::factory] methods.
*
* $request = new Request($uri);
*
*
* If $cache parameter is set, the response for the request will attempt to
* be retrieved from the cache.
*
Expand Down Expand Up @@ -1084,27 +1084,6 @@ public function create_response($bind = TRUE)
return $this->_response = $response;
}

/**
* Checks the browser cache to see the response needs to be returned.
*
* $request->check_cache($etag);
*
* [!!] If the cache check succeeds, no further processing can be done!
*
* @param string $etag Etag to check
* @return Request
* @throws Kohana_Request_Exception
* @uses Request::generate_etag
* @deprecated
*/
public function check_cache($etag = null)
{
$this->create_response()
->check_cache($etag, $this);

return $this;
}

/**
* Gets or sets the Http method. Usually GET, POST, PUT or DELETE in
* traditional CRUD applications.
Expand Down

0 comments on commit 82bbd09

Please sign in to comment.