Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error in Xcode10 beta #26

Closed
hardW opened this issue Jul 20, 2018 · 8 comments
Closed

Build error in Xcode10 beta #26

hardW opened this issue Jul 20, 2018 · 8 comments

Comments

@hardW
Copy link

hardW commented Jul 20, 2018

On Xcode 10.0 beta4 I've got two errors Invalid redeclaration of 'countableRange(from:relativeTo:)' for internal func countableRange(from range: Range<Int>, relativeTo collection: CountableRange<Int>) -> CountableRange<Int> and internal func countableRange(from range: ClosedRange<Int>, relativeTo collection: CountableRange<Int>) -> CountableRange<Int> in Util.swift

With the implementation of SE-0143 Conditional conformances in Swift 4.2, CountableRange and CountableClosedRange are not separate types relative to Range, ClosedRange, but their type aliases.

@hardW
Copy link
Author

hardW commented Jul 20, 2018

I actually don't get what for are those last 4 internal func countableRange(from range:... functions in Util.swift
Since after their deletion it compiles ok in both XCode 9 and 10

@johndpope
Copy link

screen shot 2018-08-21 at 11 22 03 am

@koher - what to do....

@johndpope
Copy link

screen shot 2018-08-21 at 11 23 49 am

@koher
Copy link
Owner

koher commented Aug 22, 2018

@hardW @johndpope
Thanks for reporting! I'll fix it.

@johndpope
Copy link

hack
github "johndpope/EasyImagy" "0.5.1"

@koher
Copy link
Owner

koher commented Aug 28, 2018

@hardW @johndpope

Hi. I checked it and found that the problems had been fixed in 69adfd0 #25 by @Dschee. Please use the swift-4.2 dev-0.6.0 branch for Xcode 10 beta.

I checked that swift test and "Product > Test" for iOS with Xcode 10.0 beta 6 passed.

@koher
Copy link
Owner

koher commented Aug 28, 2018

@hardW

Since after their deletion it compiles ok in both XCode 9 and 10

They were unused and I removed them in 45f37ab. Thanks for pointing it out.

@koher
Copy link
Owner

koher commented Aug 29, 2018

Now 0.5.0 also supports Swift 4.2.

@koher koher closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants