Update phpseclib to ver 2.0.6 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows php7 to not pollute the output with class constructor warnings
|
@markkimsal Thanks for your PR. But the travis-ci testing have failed. Can you fix it? |
|
coveralls:dev-master does not work with php-5.4 or php-5.3 anymore. |
Remove php 5.3 and 5.4 because latest coveralls doesn't support those versions.
markkimsal
force-pushed
the
features/php7-compat
branch
from
76a31f2
to
4d471e2
Compare
|
In order to support php5.3 and php5.4 someone needs to change composer.json to use coveralls 1.0.1 and run composer update and commit the composer.lock file as well as the composer.json file. I tried, but after 20 minutes stopped composer. All evidence points to php5.3 and 5.4 working, but getting travis to automatically prove this is not working at the moment. |
|
@markkimsal Now PHP5.3 and PHP5.4 are not supported versions in official PHP implementation. So we do not need to pass the tests for these versions in travis-ci. Thank you so much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows php7 to run without polluting the output with class constructor
warnings