use specified status code for inertia response #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the Inertia JSON response is always returned with an HTTP 200 status code. This process is based on the Inertia-Laravel implementation. You can see this here: see https://github.com/inertiajs/inertia-laravel/blob/af7571859cb643b206ff67083d47fb75cd7f26de/src/Response.php#L107
However, I believe it would be better to return different status codes under certain circumstances, such as a 404 error.
I have tested this and confirmed that the Inertia client-side library can accept status codes other than 200.