Patchless linuxmodule V2 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When device status changes (e.g. link bounce), if dev->br_port is not null linux bridge's br_device_event will refer to dev->br_port. But dev->br_port is a invalid pointer to linux bridge as it's fake_bridge which was allocated by FromDevice. To make linux bridge happy, set br_port to null with early notification handler and set it again with late notification handler again. Note: this fix is under *not* ideal assumption as it assumes br_device_notifier's prioriy is higher than INT_MIN and less than INT_MAX. Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
As of linux 2.6.36 file_operations.ioctl has removed. Bobby Longpocket <bobbylongpocket@yahoo.com> pointed out different interface between ioctl and unlocked_ioctl Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Linux net has removed function pointers which had used for intercepting packet from protocol handlers/pesudo devices like bridge and introduced netdev_rx_handler_register() instead. Subsequently br_handle_frame_hook is not available anymore. For patchless linux, use netdev_rx_handler_register(). Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Use per_cpu super_blocks.s_files. Detect and use lg_local_lock(files_lglock), file_list_lock() is removed. Also use kzalloc to zero initialize newfs. Recent linux calls file_system_type.mount if it's not null. Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
|
Hi Joonwoo, I believe all changes in this pull request have been integrated, so I'm going to close it. Please let me know if I was wrong, and thanks! E |
tbarbette
pushed a commit
to tbarbette/click
that referenced
this pull request
Aug 13, 2018
Batching support for some elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PATCH 1/5] FromDevice: avoid kernel panic on device status change.
[PATCH 2/5] clickfs: use unlocked_ioctl on linux 2.6.36+
[PATCH 3/5] FromDevice: use netdev_rx_handler_register
[PATCH 4/5] proclikefs: use per_cpu super_block.s_files
[PATCH 5/5] ToUserDevice: use unlocked_ioctl if it's available