Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #29 - Do not retrieve Environment variables just to get the command line #34

Merged
merged 1 commit into from Apr 12, 2017

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Mar 24, 2017

It does not resolve the issue #29 , but it reduces its scope to API users, which actually do not
require Environment Variables. Unfortunately JENKINS-30782 is of such kind, because Jenkins process termination logic for builds relies on the environment variables.

OTOH, it is still a useful performance improvement

@reviewbybees

…t the command line

It does not resolve the issue, but it reduces its scope to API users, which actually require Environment Variables.
Unfortunately JENKINS-30782 is of such kind, because Jenkins process termination logic for builds relies on the environment variables.
@ghost
Copy link

ghost commented Mar 24, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but if we are not solving JENKINS-30782, which is the bug affecting the main use case of this library IIUC, why are we doing it?

@oleg-nenashev
Copy link
Member Author

@jglick

why are we doing it?

See the PR description

It does not resolve the issue #29 , but it reduces its scope to API users, which actually do not
require Environment Variables. Unfortunately JENKINS-30782 is of such kind, because Jenkins process termination logic for builds relies on the environment variables.

In Jenkins there are cases, when the code does not invoke WinProcess#getEnvironmentVariables (). So it will reduce the frequency of the issue and also improve the performance since the code won't be reading and parsing a big memory window. So it worth the new API method

@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev oleg-nenashev merged commit 9a5d298 into jenkinsci:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants