Use jlong for HANDLE and GetProcessId instead of Nt kernel private fu… #53
Conversation
|
@oleg-nenashev as a next step we can consider using long for PIDs. Unsigned int would suffice, though, as PIDs have DWORD (32-bit, unsigned) type on Windows. |
|
@oleg-nenashev does this fix the flakiness-issue you experienced? |
|
@stephanreiter sorry, I somehow missed this pull request. Looking |
|
@oleg-nenashev Thanks!! Do you have everything in place for an alpha release of the next WinP that we can base the following Jenkins PR on? jenkinsci/jenkins#3414 |
|
Yes, the testing looks good!
I will try to get it delivered once I get internet to run just another
Windows update. Hopefully - today/tomorrow
…On Sun, Jul 15, 2018 at 9:49 PM, Stephan Reiter ***@***.***> wrote:
@oleg-nenashev <https://github.com/oleg-nenashev> Thanks!! Do you have
everything in place for an alpha release of the next WinP that we can base
the following Jenkins PR on? jenkinsci/jenkins#3414
<jenkinsci/jenkins#3414>
Would be awesome if you could support me in finishing that. :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#53 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoBu3lbWs59EdjZAFY7YstkPicli9ks5uG46cgaJpZM4U1KkF>
.
|
|
Cool! :) Thanks a lot, @oleg-nenashev |
|
@stephanreiter I have released all the patches in 1.27. Currently the release flow has some issues, because test executables are not properly built in the Maven Checkout directory. I will probably update pom.xml to always build the native binaries during the release. IIRC previously @kohsuke used to build on one machine and then release on another one, but now it's rather preferable to do everything on a single machine since the repository has more test automation now I have worked around that, but now I wait till new GPG keys get synced. It may take a while |
|
@stephanreiter this is finally out as 1.27. Last time I checked 6 days ago, GPG keys were still unsynced. But now the release went fine. Not sure why it took so long to sync... |
|
@oleg-nenashev super! How can I use 1.27 from jenkins? I updated my pull request (jenkinsci/jenkins#3414), but the build failed because of a missing https://repo.azure.jenkins.io/public/org/jvnet/winp/winp/1.27/winp-1.27.jar |
|
@stephanreiter apparently I didn't promote the repo in Maven Central properly, so it got stuck in staging. The release artifact is promoted now, I will retrigger your build |
…nction
HANDLE is a typedef for a void*. On Win64 we cannot safely wrap that in a 32-bit int, so switch to 64-bit long. The hope is that this fixes random test failures that occur more when the system had been under load recently (and therefore has more open/recently closed handles).