Check format by ruff #1055
Open
Check format by ruff #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shirayu
force-pushed
the
check_by_ruff
branch
from
8e3142b
to
ce0641c
Compare
|
Nice 😄 When actually applying the reformatting, we should note it will practically invalidate all current PRs (since there will be conflicts everywhere). Regarding "Use more rules of ruff for static analysis", I actually applied some in main...akx:sd-scripts:import-cleanup (it builds on the IPEX cleanup in #1054 so I'm not making a PR out of it yet). |
|
Updated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replaced PR of #902.
Add black format check every commit
This helps keep code readability at all times
Currently, the formatting has not been done. So the test will be failed ( ❌ ). Please perform formatting at the appropriate time.
Additional considerations related to this PR