update resize_lora.py (fix out of bounds and index) #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error where index may go out of bounds when using certain dynamic parameters. Fix index and rank issue (previously some parts of code was incorrectly using python index position rather than rank, which is -1 dim).
|
Thank you for this! I didn't fully understand the theory, but it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error where index may go out of bounds when using certain dynamic parameters (see issue: Resizing of extracted lora giving error
IndexError: index 320 is out of bounds for dimension 0 with size 320#325)Fix index and rank issue (previously some parts of code were incorrectly using python index position of the rank rather than the actual rank, resulting in -1 of the actual dim). Practically speaking, no one needs to "re" re-size any previous LoRA if the results are satisfactory.
Also some minor code refactoring and labeled some chunks of code.