-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model metadata editor and hashing update #45
Conversation
Should be faster on SSDs but I only have an HDD to test right now
ac15edf
to
40ba669
Compare
Thank you for great PRs! However, I am a little worried about my ability to maintain it in the future. In addition, I also plan to add other networks (such as Hypernetwork or Custom Diffusion etc...) and other features in the future. It might be an idea to create another extension for these networks, but the single extension will be good to control their orders and weights. Do you think it would be possible to implement the metadata editor in a separate file as much as possible? I think that would keep the file |
Yeah, probably a good idea, I can implement the hashing changes separately I think metadata editing is too ahead of its time since there's no model browser yet anyway |
Thank you for your consideration. I agree that it is too ahead 😅. But I think it is definitely useful. In addition, at this point, it might be nice to have an item that allows the user to specify an arbitrary string when training the model, such as "ss_training_comment" by a command-line argument. That would be helpful for not only the user of the model but also the user to train. |
I think the comment could be helpful but the model trainer won't know how it turns out beforehand, so I'm not sure it will be 100% useful I was mainly trying to solve the issue of having a For metadata standardizing, the items with Once there's a proper model browser where the cover images can be organized in an actually useful way, this kind of thing will probably gain more adoption than right now |
Adds a metadata editor for LoRA models. Now people won't have to put the instructions or cover images in separate files where they can get lost. It can also save ratings, activation keywords and tags, for a future model browser component
Also updates the hashing methodology to be more resiliant like webui's new algorithm. This hash change should not affect old seeds since the "legacy" hash is also calculated for each model upfront, unlike what webui is currently doing (only calculating/caching the hash if a model is loaded)
Some deficits:
sd-scripts
firsttorch.Tensor
s in-memory, alleviating the need for serializing the extra time, but it was 80% slower than hashing the raw file's bytes. Again, might be different if a SSD is used, but it's a difference between 15 minutes and 40 minutes, and the two types of hashes are incompatible with each othergr.Gallery()
doesn't support uploading: AllowGallery
to be used as in input component and upload multiple images gradio-app/gradio#1379