Skip to content

Commit

Permalink
Deprecate passing a column to type_cast
Browse files Browse the repository at this point in the history
Follow up to rails/rails#39106.
  • Loading branch information
koic committed May 2, 2020
1 parent 125c064 commit 38f5b97
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,11 @@ class ::TestItem < ActiveRecord::Base
columns = @conn.columns("test_items")
%w(nchar_column nvarchar2_column char_column varchar2_column).each do |col|
column = columns.detect { |c| c.name == col }
value = @conn.type_cast_from_column(column, "abc")
type = @conn.lookup_cast_type_from_column(column)
value = type.serialize("abc")
expect(@conn.quote(value)).to eq(column.sql_type[0, 1] == "N" ? "N'abc'" : "'abc'")
nilvalue = @conn.type_cast_from_column(column, nil)
type = @conn.lookup_cast_type_from_column(column)
nilvalue = type.serialize(nil)
expect(@conn.quote(nilvalue)).to eq("NULL")
end
end
Expand Down

0 comments on commit 38f5b97

Please sign in to comment.