[Fix rubocop#113] Fix an error for Minitest/AssertEqual

Fixes rubocop#113. This PR fixes an error for `Minitest/AssertEqual` and some cops when using `assert` with block argument.
koic · Dec 24, 2020 · ad0c3e9 · ad0c3e9
1 parent da04056
commit ad0c3e9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#113](https://github.com/rubocop-hq/rubocop-minitest/issues/113): This PR fixes an error for `Minitest/AssertEqual` and some cops when using `assert` with block argument. ([@koic][])
+
 ## 0.10.1 (2020-07-25)
 
 ### Bug fixes

diff --git a/lib/rubocop/cop/mixin/minitest_cop_rule.rb b/lib/rubocop/cop/mixin/minitest_cop_rule.rb
@@ -57,7 +57,7 @@ def autocorrect(node)
           private
 
           def peel_redundant_parentheses_from(arguments)
-            return arguments unless arguments.first.begin_type?
+            return arguments unless arguments.first&.begin_type?
 
             peel_redundant_parentheses_from(arguments.first.children)
           end

diff --git a/test/rubocop/cop/minitest/assert_equal_test.rb b/test/rubocop/cop/minitest/assert_equal_test.rb
@@ -132,4 +132,11 @@ def test_do_something
       end
     RUBY
   end
+
+  # See: https://github.com/rubocop-hq/rubocop-minitest/issues/113
+  def test_does_not_register_offense_when_assert_with_block_argument
+    assert_no_offenses(<<~RUBY)
+      assert { 1 + 2 == 3 }
+    RUBY
+  end
 end