Skip to content

Commit

Permalink
Fix a build error
Browse files Browse the repository at this point in the history
This PR prevents the following build error:

```console
NoMethodError:
  undefined method `cop_name' for nil
# ./lib/rubocop/cop/badge.rb:52:in `match?'
# ./lib/rubocop/cop/registry.rb:300:in `resolve_badge'
# ./vendor/bundle/ruby/3.3.0/gems/rubocop-rspec_rails-2.28.3/lib/rubocop-rspec_rails.rb:30:in `qualified_cop_name'
```

https://github.com/rubocop/rubocop/actions/runs/8656558784/job/23737409762

This error is due to a monkey patch in rubocop-rails_rails:
rubocop/rubocop-rspec_rails#14

The monkey patch in rubocop-rspec_rails should also be fixed, but this patch prevents RuboCop from failing due to dependencies.
RuboCop does not depend on Rails, so the ideal solution would be to remove the dependency on rubocop-rspec_rails gem.
However, this is not possible currently because rubocop-rspec is still dependent on it.
  • Loading branch information
koic committed Apr 12, 2024
1 parent 92513d3 commit 4e7b3df
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/rubocop/cop/badge.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ def hash
end

def match?(other)
# Prevents the following error:
# https://github.com/rubocop/rubocop/actions/runs/8656558784/job/23737409762
return false if other.nil?

cop_name == other.cop_name && (!qualified? || department == other.department)
end

Expand Down

0 comments on commit 4e7b3df

Please sign in to comment.