Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter to specify odom target frame #39

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

ricber
Copy link
Contributor

@ricber ricber commented Mar 27, 2020

I've made the following changes:

  • I've added in the launch file the <remap> tags to remap the points topic and the imu topic
  • I've added a parameter to specify the target frame against which to compute the odometry. This is useful, for example, if you are using a sensor like the Ouster OS-1 that is characterized by three frame_id, namely, os1_sensor, os1_lidar, and os1_imu. Moreover, it is very common in the robotics world to compute the odometry against the base_link frame.
  • To compute the odometry against a given target frame I've added an instruction to transform the input point cloud into the target frame via a pcl_ros library function. If the target odom_child_frame_id is the same as that of the input point cloud msg, no transformation is performed.

This pull request closes #38

@koide3
Copy link
Owner

koide3 commented Mar 30, 2020

Thanks a lot for the pull request. I'll review and merge it soon 👍

@koide3 koide3 merged commit a76067c into koide3:master Apr 6, 2020
@koide3
Copy link
Owner

koide3 commented Apr 6, 2020

I confirmed that this modification works fine and merged it. Thanks again!

narutojxl pushed a commit to narutojxl/hdl_localization_noted that referenced this pull request Mar 24, 2022
Parameter to specify odom target frame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point clouds frame_id different than sensor frame_id
2 participants