Fixed error in the Helper::isPlaceholder method

koinephp · Sep 8, 2014 · 970c598 · 970c598
1 parent 7158efb
commit 970c598
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/Koine/QueryBuilder/Helper.php b/lib/Koine/QueryBuilder/Helper.php
@@ -121,7 +121,7 @@ public function isString($value)
      */
     public function isPlaceholder($value)
     {
-        return preg_match('/^\:[_a-zA-Z]+$/', $value) === 1;
+        return preg_match('/^\:[_a-zA-Z]/', $value) === 1;
     }
 
     /**

diff --git a/tests/KoineTests/QueryBuilder/HelperTest.php b/tests/KoineTests/QueryBuilder/HelperTest.php
@@ -73,12 +73,14 @@ public function itQuotesValue()
      */
     public function itVerifiesIfValueIsPlaceholder()
     {
+        $this->assertTrue($this->o->isPlaceholder(':placeholder2'));
         $this->assertTrue($this->o->isPlaceholder(':placeholder'));
         $this->assertTrue($this->o->isPlaceholder(':placeHolder'));
         $this->assertTrue($this->o->isPlaceholder(':place_Holder'));
         $this->assertFalse($this->o->isPlaceholder('s:st'));
         $this->assertFalse($this->o->isPlaceholder('string'));
         $this->assertFalse($this->o->isPlaceholder('1'));
+        $this->assertFalse($this->o->isPlaceholder(':11'));
     }
 
     /**