fix(cli): await for plugin dispose before reloading

packages/koishi-core/src/context.ts

@@ -201,8 +201,6 @@ export class Context {
     ]).finally(() => {
       this.app.registry.delete(plugin)
       remove(state.parent.children, plugin)
-      const index = state.parent.children.indexOf(plugin)
-      if (index >= 0) state.parent.children.splice(index, 1)
       this.emit('registry', this.app.registry)
     })
   }

packages/koishi/src/worker.ts

@@ -203,7 +203,7 @@ function createWatcher() {
 
   const logger = new Logger('app:watcher')
 
-  watcher.on('change', (path) => {
+  watcher.on('change', async (path) => {
     if (!require.cache[path] || externals.has(path)) return
     logger.debug('change detected:', path)
 
@@ -214,7 +214,8 @@ function createWatcher() {
     declined.delete(path)
 
     const plugins: string[] = []
-    for (const [filename] of pluginMap) {
+    const tasks: Promise<void>[] = []
+    for (const [filename, [name]] of pluginMap) {
       const dependencies = loadDependencies(filename, declined)
       if (dependencies.has(path)) {
         dependencies.forEach(dep => accepted.add(dep))
@@ -224,10 +225,15 @@ function createWatcher() {
 
         // dispose installed plugin
         plugins.push(filename)
-        app.dispose(plugin)
+        const displayName = plugin.name || name
+        tasks.push(app.dispose(plugin).catch((err) => {
+          logger.warn('failed to dispose plugin %c\n' + coerce(err), displayName)
+        }))
       }
     }
 
+    await Promise.all(tasks)
+
     accepted.forEach(dep => delete require.cache[dep])
     for (const filename of plugins) {
       const plugin = require(filename)