fix(teach): fix incorrect auth checks for context, fix #208

koishijs · Apr 9, 2021 · 89d53b1 · 89d53b1
1 parent 6c59d86
commit 89d53b1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,5 +1,6 @@
 atri
 dist
+lib
 build/*.js
 
 /build/*.js
diff --git a/packages/plugin-teach/src/plugins/context.ts b/packages/plugin-teach/src/plugins/context.ts
@@ -33,7 +33,7 @@ export default function apply(ctx: Context, config: Dialogue.Config) {
     .option('enableGlobal', '-E  在所有环境下启用问答', { authority })
     .option('groups', '-g <gids:string>  设置具体的生效环境', { authority, type: RE_GROUPS })
     .option('global', '-G  无视上下文搜索')
-    .check(({ options, session }) => {
+    .action(({ options, session }) => {
       if (options.disable && options.enable) {
         return '选项 -d, -e 不能同时使用。'
       } else if (options.disableGlobal && options.enableGlobal) {

diff --git a/packages/plugin-teach/tests/context.spec.ts b/packages/plugin-teach/tests/context.spec.ts
@@ -4,7 +4,7 @@ const DETAIL_HEAD = '编号为 1 的问答信息：\n问题：foo\n回答：bar\
 const SEARCH_HEAD = '问题“foo”的回答如下：\n'
 
 describe('Teach Plugin - Context', () => {
-  const { u3, u3g1, u3g2 } = createEnvironment({ useContext: true })
+  const { u3, u3g1, u3g2, u2g1 } = createEnvironment({ useContext: true })
 
   it('validate options 1', async () => {
     await u3.shouldReply('# foo bar', '非群聊上下文中请使用 -E/-D 进行操作或指定 -g, --groups 选项。')
@@ -68,4 +68,9 @@ describe('Teach Plugin - Context', () => {
     await u3g1.shouldReply('#1', DETAIL_HEAD + '生效环境：除本群')
     await u3g1.shouldReply('## foo -G', SEARCH_HEAD + '1. [d] bar')
   })
+
+  it('validate options 3', async () => {
+    await u2g1.shouldReply('# foo baz -E', '权限不足。')
+    await u2g1.shouldReply('# foo baz', '问答已添加，编号为 2。')
+  })
 })