Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): improvements #212

Merged
merged 9 commits into from
Apr 10, 2021
Merged

fix(discord): improvements #212

merged 9 commits into from
Apr 10, 2021

Conversation

XxLittleCxX
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #212 (dcf8c56) into develop (4f80be4) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
+ Coverage    92.34%   92.56%   +0.22%     
===========================================
  Files           53       53              
  Lines        10638    10645       +7     
  Branches      2176     2251      +75     
===========================================
+ Hits          9824     9854      +30     
+ Misses         814      791      -23     
Impacted Files Coverage Δ
packages/koishi-core/src/session.ts 99.58% <0.00%> (+3.30%) ⬆️
packages/koishi-utils/src/segment.ts 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f80be4...dcf8c56. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2021

This pull request introduces 1 alert when merging 5e18f32 into 4f80be4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@@ -9,6 +9,18 @@ import { segment } from 'koishi-utils'
import FormData from 'form-data'
import FileType from 'file-type'

export class SenderError extends Error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

于是乎这个 1.0 时期就有的古董类被你们抄进了每一个 adapter……我已经开始考虑要不要直接从 koishi-core 导出了……当然不是这个 PR 该干的事情就是了,我随便吐槽而已。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但我昨天加了个试了下发现没啥用,丢出来的还是axios又长又烂的exception,丢人

packages/adapter-discord/src/index.ts Outdated Show resolved Hide resolved
packages/adapter-discord/src/types.ts Outdated Show resolved Hide resolved
packages/adapter-discord/src/utils.ts Show resolved Hide resolved
packages/adapter-discord/src/utils.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 1 alert when merging c7ff481 into b429522 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request fixes 1 alert when merging 46802dd into 691b7c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request fixes 1 alert when merging dcf8c56 into 691b7c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@shigma shigma merged commit a280e52 into develop Apr 10, 2021
@XxLittleCxX XxLittleCxX deleted the develop-discord branch April 10, 2021 14:31
shigma added a commit that referenced this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants