Fix (or suppress) warnings on the first REPL startup. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukamachi
commented
Aug 1, 2021
| @@ -6,7 +6,8 @@ exec ros -Q -L sbcl-bin -- $0 "$@" | |||
| (progn ;;init forms | |||
| (ros:ensure-asdf) | |||
| (unless (find-package :cl-repl) | |||
| (ql:quickload :cl-repl :silent t))) | |||
| (handler-bind ((asdf:bad-system-name #'muffle-warning)) | |||
There was a problem hiding this comment.
This suppresses the following ASDF warning:
WARNING: System definition file #P"/home/fukamachi/.roswell/lisp/quicklisp/dists/quicklisp/software/cl-ppcre-20190521-git/cl-ppcre.asd" contains definition for system "cl-ppcre-test". Please only define "cl-ppcre" and secondary systems with a name starting with "cl-ppcre/" (e.g. "cl-ppcre/test") in that file.
fukamachi
commented
Aug 1, 2021
| @@ -6,7 +6,8 @@ exec ros -Q -L sbcl-bin -- $0 "$@" | |||
| (progn ;;init forms | |||
| (ros:ensure-asdf) | |||
| (unless (find-package :cl-repl) | |||
| (ql:quickload :cl-repl :silent t))) | |||
| (handler-bind ((asdf:bad-system-name #'muffle-warning)) | |||
There was a problem hiding this comment.
This suppresses the following ASDF warning:
WARNING: System definition file #P"/home/fukamachi/.roswell/lisp/quicklisp/dists/quicklisp/software/cl-ppcre-20190521-git/cl-ppcre.asd" contains definition for system "cl-ppcre-test". Please only define "cl-ppcre" and secondary systems with a name starting with "cl-ppcre/" (e.g. "cl-ppcre/test") in that file.
fukamachi
commented
Aug 1, 2021
| (multiple-value-bind (options free-args) | ||
| (handler-case | ||
| (if argv (opts:get-opts argv) (opts:get-opts)) | ||
| (error () | ||
| (format t "try `cl-repl --help`.~&") | ||
| (uiop:quit 1))) | ||
| (declare (ignore free-args)) |
There was a problem hiding this comment.
This fixes the following style-warning:
; caught STYLE-WARNING:
; The variable FREE-ARGS is defined but never used.
fukamachi
commented
Aug 1, 2021
| @@ -61,13 +61,14 @@ | |||
| (rl:register-function :complete #'completer) | |||
| (install-inspector)) | |||
|
|
|||
| (defun main (&optional argv &key (show-logo t)) | |||
| (defun main (argv &key (show-logo t)) | |||
There was a problem hiding this comment.
This fixes the following style-warning on SBCL:
; caught STYLE-WARNING:
; &OPTIONAL and &KEY found in the same lambda list: (&OPTIONAL ARGV &KEY
; (SHOW-LOGO T))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll leave GitHub comments for each line.