Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and Code Refactoring #242

Closed
wants to merge 8 commits into from
Closed

Conversation

Advik-B
Copy link

@Advik-B Advik-B commented Oct 24, 2023

The base code refactoring is provided by Sourcery Advik-B#1

Hotfix 1: Fix SSL warning/error 17a4f46 784f0ff

Hotfix 2: Fixing a parsing error https://github.com/jsavargas/zspotify/issues/149#issuecomment-1773865540

@kokarare1212
Copy link
Owner

The new method of obtaining expiration dates has already been implemented in this commit.
It is also dangerous to disable SSL verification.

@Advik-B
Copy link
Author

Advik-B commented Oct 24, 2023

The new method of obtaining expiration dates has already been implemented in this commit. It is also dangerous to disable SSL verification.

Do you want me to re-enable SSL?

@kokarare1212
Copy link
Owner

Perhaps what this PR needs is a reference tag, and Restyled.io has already done that.

@Advik-B
Copy link
Author

Advik-B commented Oct 25, 2023

Perhaps what this PR needs is a reference tag, and Restyled.io has already done that.

Alright, ill re-enable ssl, what else?

@kokarare1212
Copy link
Owner

Anyway, this PR is no longer needed as a temporary solution has been implemented.
#241

@kokarare1212 kokarare1212 added bug Something isn't working duplicate This issue or pull request already exists labels Oct 29, 2023
@Advik-B
Copy link
Author

Advik-B commented Nov 8, 2023

Fineee 😞

@Advik-B Advik-B closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants