Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of $_SERVER['HTTP_HOST'] #58

Open
bastilian opened this issue Oct 24, 2017 · 0 comments
Open

Use of $_SERVER['HTTP_HOST'] #58

bastilian opened this issue Oct 24, 2017 · 0 comments

Comments

@bastilian
Copy link

Koken uses $_SERVER['HTTP_HOST'] as a base for building URL for assets and links. Depending on how Koken is hosted this can vary from the actual public hostname and lead to several issues. Additionally the variable can be altered by requests with the host header[1].

A possible solution would be to respect $config['base_url'] and set it in case no config for it is provided.

[1] https://expressionengine.com/blog/http-host-and-server-name-security-issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant