Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox in full screen: images missing + can't close overlay #59

Open
humantex opened this issue Nov 12, 2017 · 0 comments
Open

Lightbox in full screen: images missing + can't close overlay #59

humantex opened this issue Nov 12, 2017 · 0 comments

Comments

@humantex
Copy link

There seems to be a couple of sporadic issues with the the lightbox functionality in Koken. I've overridden some minor lightbox CSS calls for the sake of introducing a bit of padding and the use of FontAwesome icons for forward/back arrows - but no other modifications to js files or other code to alter how it should work.

1... is a problem with image display when the lightbox is in full-screen mode:

I don't always double check that all the various image sizes are created when I import new images - and obviously I don't have access to every device to verify every one. - but - on a recent run through of some added photos, there are several that just don't show up, or they might even show a duplicate of a different entry. I've checked it on my desktop (1920px), laptop (1440px), tablet (1280px), and phone (1280px in landscape) and it happens with every browser - and after a full cleaning of the browser cache on any device. The problem usually occurs for the 2 largest sized image files. 99% of my files are 1600px or less in width, and between 200k-500k max, size - with most in the 300k range - so I doubt it's a timeout issue with size conversions not completing, given the ample resource settings I have.

koken_image-sizes
A screen-grab of my image size settings. Also... using ImageMagick 6.7.2

I had a similar issue quite some time ago and I cleared the system and image caches in Koken, which seemed to force a fix. I haven't yet done that this time around in the event that whatever issue is causing it would be difficult to diagnose, but it takes it's toll on my host's resources to force a rebuild and I'd prefer to not have to resort to doing it often.

Example 5 image album, with 4 using the preset 1600px X-Large image size that's exhibiting all of the issues: https://lumiworx.com/albums/black-white/

2... is an issue of closing the full-screen lightbox overlay once it's been opened. The only fail-safe way to ensure it gets closed is to use the 'escape' key functionality. Using the 'X' to close it, or the double-arrow to toggle it won't work when there's a display issue with content. In other words - when all the images are there for display - in any device size I have to check them with - I can use any of the expected methods successfully to both open and close the overlay. If there's an issue with loading any image(s), 2 of the 3 methods won't work.

Again... this behavior happens in every browser I have, with or without an empty browser cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant