Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute img URLs in slideshows and img paths #8

Closed
BlackSkorpio opened this issue Feb 10, 2016 · 6 comments
Closed

Absolute img URLs in slideshows and img paths #8

BlackSkorpio opened this issue Feb 10, 2016 · 6 comments
Assignees

Comments

@BlackSkorpio
Copy link

I'm assuming you using something like:
{{ location.site_url }}/{{content.filename }}
When building the src url for images and slideshows

Replacing that with something like
{{ location.root_folder }}/{{content.filename }}

Would make life much easier for people serving the same site with multiple domains

@MikeCostello MikeCostello self-assigned this Apr 6, 2016
@BlackSkorpio
Copy link
Author

A note should be made that these absolute paths will/can also break a site when using SSL since it many times refers to the non-SSL site (When going from non-SSL to enforcing SSL via htaccess or even apache config).

@Hard-One
Copy link

Actually it is like you describe it. It is currently impossible to use SSL because those absolute paths always refer to http and not https.
I think this is essential especially for those considering using the cart plugin.

@Hard-One
Copy link

Manually deleting the cache folders did the trick to rebuild the urls for https on my site. But for all essays and pages one must re-puplish them in order to rebuild the urls inside them. For sites with a lot of essays and pages this is not an option.

@BlackSkorpio
Copy link
Author

Hi there @MikeCostello is there any progress done with this issue?

@MikeCostello
Copy link
Contributor

@BlackSkorpio
Copy link
Author

Looks good and solid, have it running on both sites right now; guess we can close this one then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants