Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot testing #48

Merged
merged 9 commits into from
Feb 15, 2021
Merged

snapshot testing #48

merged 9 commits into from
Feb 15, 2021

Conversation

kokes
Copy link
Owner

@kokes kokes commented Feb 11, 2021

seems like it will be doable via jsdom

to resolve:

  • rename tests to test_cases?
  • pin marked, katex, prism to the same versions as those CDNed (maybe in a separate PR, this will require testing)
  • clean up the constructor in nbv.js
  • make the HTML version into a working one
  • module.exports won't work in the browser, find a workaround
  • set up CI, add more examples etc.?
  • throw exceptions instead of console.errors
  • do not style the main div
  • upload more test cases here
  • walk directory with test cases to test them all
  • fix katex errors

@kokes
Copy link
Owner Author

kokes commented Feb 15, 2021

I downloaded a sample from this piece of research by JetBrains link, it will be useful for testing.

It's a public S3 bucket, so it was as easy as aws s3 sync s3://github-notebooks-update1/ data/ (need to Control-C it, there's a lot of data)

@kokes kokes merged commit 08eff71 into master Feb 15, 2021
@kokes kokes deleted the testing branch February 16, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant