-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid generated public key #12
Comments
Hi @bloobird0 and thanks for your interest in this library :) As far as I know, the only problem would be big endianness processors, which would require you to byte-swap the const numerals, as mentioned in #5
Can you please check the return value of the call to |
Hello,
I have changed the init value of the public key (I initialized prior with 0x00 now with 0xBB) and it seems that bytes 0 to 2 are set to 0x00. The others are unchanged at 0xBB. The generated private key is: |
Hi @bloobird0 - did you ever get this fixed? I am wondering if I could have fixed this issue, when I fixed #10. If possible and at your leisure, could you please try again with the updated code, and give me your feedback on this? I would love to have a success story for referral ;) |
Hello,
thanks for your work. I wanted to play with your implementation on both a 64 bits PC and a 16bits PIC24F µC. I played with k163 curve.
On PC, it works like a charm (although it generates a public key filled with 0x00 when I build in release and works in debug) but on the PIC24F, it takes around 30s (!) to execute ecdh_generate_keys() and the final result is a public key filled with 0x00. May I have incorrectly used it so that it generates such a public key? Is the implementation supposed to work on 16bits CPUs?
The text was updated successfully, but these errors were encountered: