Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some KokkosBlas kernels assume default execution space #14

Closed
mhoemmen opened this issue Mar 20, 2017 · 4 comments
Closed

Some KokkosBlas kernels assume default execution space #14

mhoemmen opened this issue Mar 20, 2017 · 4 comments
Assignees
@lucbv
Labels
bug fixed-in-develop bug InDevelop

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Mar 20, 2017 •
edited

The implementation of KokkosBlas::dot incorrectly assumes the default execution space, by using expressions like Kokkos::parallel_reduce(numRows, op);, instead of an explicit Kokkos::RangePolicy<execution_space, ...>. Check other KokkosBlas kernels as well.
@mhoemmen mhoemmen changed the title KokkosBlas::dot assumes default execution space for single-vector kernels Some KokkosBlas kernels assume default execution space Mar 21, 2017
@crtrott
Copy link
Member

crtrott commented Dec 4, 2018

Can someone check whether this is still an issue.

@lucbv
Copy link
Contributor

lucbv commented Dec 5, 2018

@crtrott this has been fixed in KokkosBlas::dot and it does not appear in other Blas functions.

@ndellingwood
Copy link
Contributor

Marking as bug fixed and in develop.

@mhoemmen
Copy link
Contributor Author

Thanks all!

@ndellingwood ndellingwood mentioned this issue Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

Labels
bug fixed-in-develop bug InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mhoemmen @crtrott @ndellingwood @lucbv