New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos + KokkosKernels Promotion to 2.8.00 #4329
Conversation
Changes to coordinate with kokkos/kokkos#1886. Various ViewMapping partial specializations now require the final template parameter to be the specialize tag, rather than explicit void. These changes ensure Sacado and Stokhos compatibility with the Kokkos changes. Test with Cuda_Serial build on waterman with cuda/9.2+gcc/7.2 Changes to be committed: modified: packages/sacado/src/KokkosExp_View_Fad.hpp modified: packages/sacado/src/KokkosExp_View_Fad_Contiguous.hpp modified: packages/sacado/src/Kokkos_DynRankView_Fad.hpp modified: packages/sacado/src/Kokkos_DynRankView_Fad_Contiguous.hpp modified: packages/sacado/test/UnitTests/Fad_KokkosTests_Cuda.cpp modified: packages/stokhos/src/sacado/kokkos/pce/KokkosExp_View_UQ_PCE_Contiguous.hpp modified: packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp
Remove additional argument to view ctor. Changes to be committed: modified: stokhos/src/sacado/kokkos/Stokhos_Tpetra_Utilities.hpp
…549b57 From repository at git@github.com:kokkos/kokkos.git At commit: commit 5d6e7fb38e96aec88d2c514e1f9be1cf2b549b57 Merge: 9614f72 d1659d1 Author: Nathan Ellingwood <ndellin@sandia.gov> Date: Tue Feb 5 17:10:27 2019 -0700 Merge branch 'develop' for 2.8.00 Part of Kokkos C++ Performance Portability Programming EcoSystem 2.8
…1763439cb56039 From repository at git@github.com:kokkos/kokkos-kernels.git At commit: commit 4ee5f3c6dbd0981f6d8c7a9b2b1763439cb56039 Merge: 94456cf 6a79032 Author: Nathan Ellingwood <ndellin@sandia.gov> Date: Tue Feb 5 17:13:18 2019 -0700 Merge branch 'develop' for 2.8.00 Part of Kokkos C++ Performance Portability Programming EcoSystem 2.8
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Cross-referencing the Kokkos promotion 2.8.00 issue (where testing tracked) kokkos/kokkos#1981 Other likely interested parties: @mhoemmen @ZUUL42 @william76 |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the individual commits were reviewed in the Kokkos side. The integration tests pass. @ndellingwood Thanks for taking care of this quickly.
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ srajama1 ]! |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Testing results from kokkos/kokkos#1981 Testing 1
White Cuda Kepler NodesTrilinos pristine: develop branch SHA 80e2cb3 SummaryCompilation - No new build failures This test failure was fixed with PR kokkos/kokkos-kernels#381 pattern matching existing fix in Trilinos that tests this case. Results of a rerun with that updated:
White OpenMPTrilinos pristine: develop branch SHA 80e2cb3 SummaryCompilation - No new build failures White Cuda + Complex_Double Kepler NodesTrilinos pristine: develop branch SHA ac4762e SummaryCompilation - No new build failures Blake SerialTrilinos pristine: develop branch SHA 80e2cb3 SummaryCompilation - No new build failures This test failure was fixed with PR kokkos/kokkos-kernels#381 pattern matching existing fix in Trilinos that tests this case. Blake PthreadsTrilinos pristine: develop branch SHA 80e2cb3 SummaryCompilation - No new build failures This test failure was fixed with PR kokkos/kokkos-kernels#381 pattern matching existing fix in Trilinos that tests this case. Testing 2
White cuda-9.2-opt-Kepler37Build 1: Updated Trilinos, deprecated code disabledTrilinos updated: kokkos-promotion branch SHA 80e2cb3 (before snapshot) Reproducer instructions
SummaryCompilation - No build failures
Several pre-existing Panzer failures when deprecated code disabled (occurring in builds with Trilnios VOTD develop branch). Failures indicate view(s) constructed with more arguments than dynamic rank. White cuda-9.2-debug-Kepler37Build 2: Updated Trilinos, deprecated code disabled, debugging onTrilinos updated: kokkos-promotion branch SHA 80e2cb3 (before snapshot) Reproducer instructions
SummaryCompilation - No build failures Several existing Panzer failures when deprecated code disabled (View constructed with more arguments than dynamic rank) Same as above Waterman cuda-9.2-opt (Volta)Build: Updated Trilinos, deprecated code disabled, debugging onTrilinos updated: kokkos-promotion branch SHA 80e2cb3 (before snapshot) Reproducer instructions
SummaryCompilation - Build failures in Ifpack2 (deprecated code disabled) fixed in kokkos-promotion branch Several existing Panzer failures when deprecated code disabled (View constructed with more arguments than dynamic rank) Same as above Blake Pthreads RetestingWith PR kokkos/kokkos#1980 Trilinos pristine: develop branch SHA 967ff0a SummaryNo new build failures Existing test failures for reference:
|
PR testing successful, merging! |
This promotes Kokkos and KokkosKernels to Version 2.8.00.
@trilinos/kokkos @trilinos/kokkos-kernels
This update includes the following:
Kokkos
Volta fixes, C++14 support and testing, Capability to add environment variables for all command line arguments, Threads RangePolicy fix for offsets, RemoteMemorySpace support
KokkosKernels
BLAS TPL + build system fixes (Complex API, fortran mangling), C++14 support and testing, Batched GETRS
Kokkos Changelog
2.8.00 (2019-02-05)
Full Changelog
Implemented enhancements:
Fixed bugs:
KokkosKernels Changelog
2.8.00 (2019-02-05)
Full Changelog
Implemented enhancements:
Fixed bugs: