C++14 Workaround issue #349 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
approved these changes
Dec 11, 2018
| @@ -46,6 +46,14 @@ | |||
|
|
|||
| #include<Kokkos_Core.hpp> | |||
|
|
|||
| #ifdef KOKKOS_ENABLE_CXX14 | |||
There was a problem hiding this comment.
This is not a blocker, but one-liners are nice:
#if defined(KOKKOS_ENABLE_CXX14) && defined(KOKKOS_COMPILER_GNU) && KOKKOS_COMPILER_GNU <= 720
# define KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND
#endif 
kyungjoo-kim
approved these changes
Dec 14, 2018
|
@kyungjoo-kim Were you able to test this on white. It would be nice to merge this in. |
| Kokkos::parallel_for(Kokkos::ThreadVectorRange(team,blockDim_i), [&] (const int i) { | ||
| #ifdef KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND | ||
| const int idx_j = offset_j+j; | ||
| #endif |
There was a problem hiding this comment.
It probably necessary to pu int idx_j = offset_j + j with #else.
There was a problem hiding this comment.
Oh... sorry... I just saw that the idx_j is defined on the above.
|
It is okay with white. Plz, merge this PR. |
|
@kyungjoo-kim Thank you ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes C++14 build issues.