Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory pool default constructor does not properly set member variables. #1007

Closed
kyungjoo-kim opened this issue Aug 1, 2017 · 1 comment
Closed

memory pool default constructor does not properly set member variables. #1007

kyungjoo-kim opened this issue Aug 1, 2017 · 1 comment
Assignees
@hcedwar
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
On-node Task DAG
Milestone
2017 October

Comments

@kyungjoo-kim
Copy link
Contributor

Hi,

MemoryPool pool = MemoryPool();
cout << pool.capacity() << "\n";

This returns garbage values (not zero). The constructor use MemoryPool() = default.
@hcedwar hcedwar added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Aug 1, 2017
@hcedwar hcedwar added this to the 2017-September (mid) milestone Aug 1, 2017
@kyungjoo-kim
Copy link
Contributor Author

FYI: when I print_state, I got the following.

pool_size(7493989779944505344) superblock_size(2097152)

hcedwar added a commit to hcedwar/kokkos that referenced this issue Aug 1, 2017
@hcedwar
Fix kokkos#1007 : Provide explicit MemoryPool default constructor.
0f07ab5
@hcedwar hcedwar mentioned this issue Aug 1, 2017
Merged
@hcedwar hcedwar self-assigned this Aug 1, 2017
hcedwar added a commit that referenced this issue Aug 2, 2017
@hcedwar
Merge pull request #1008 from hcedwar/develop
17be2f0 
Fix #1007 : Provide explicit MemoryPool default constructor.
@hcedwar hcedwar added this to In Develop in On-node Task DAG Aug 7, 2017
@ibaned ibaned closed this as completed Aug 16, 2017
@hcedwar hcedwar moved this from In Develop to Done in On-node Task DAG Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
No open projects
On-node Task DAG
Done
Milestone
2017 October
Development

No branches or pull requests
3 participants
@ibaned @kyungjoo-kim @hcedwar