Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDRange policy doesn't support lambda reductions #1054

Closed
ibaned opened this issue Aug 23, 2017 · 5 comments
Closed

MDRange policy doesn't support lambda reductions #1054

ibaned opened this issue Aug 23, 2017 · 5 comments
Assignees
@ndellingwood
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 February

Comments

@ibaned
Copy link
Contributor

ibaned commented Aug 23, 2017

No description provided.

@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label Aug 23, 2017
@ibaned ibaned added this to the 2017-September (mid) milestone Aug 23, 2017
@hcedwar
Copy link
Contributor

hcedwar commented Aug 30, 2017

@ibaned : Need clarification, is this when using a lambda body with a custom reduction?

@ibaned
Copy link
Contributor Author

ibaned commented Aug 30, 2017

Correct, lambda body with either custom reducers, Kokkos-provided reducers, or the default reducer which is a sum. In fact, I think these compile with host backends but don't seem to compile with the CUDA backend.

@hcedwar hcedwar modified the milestones: 2017 September, 2017 October Sep 13, 2017
@hcedwar hcedwar modified the milestones: 2017 October, 2017 December Sep 26, 2017
@hcedwar hcedwar modified the milestones: 2017 December, 2018 February Nov 29, 2017
@ndellingwood
Copy link
Contributor

See #1379

ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Feb 1, 2018
@ndellingwood
MDRangePolicy: Lambda fix
fb6e94e 
Commit addresses issue kokkos#1379 and kokkos#1054
Fix to allow lambda with MDRangePolicy within parallel_for and
parallel_reduce
Unit test with lambda added for ranks 1 to 6
@ndellingwood ndellingwood mentioned this issue Feb 1, 2018
Merged
@ndellingwood
Copy link
Contributor

PR #1380 in for this issue.

@ndellingwood ndellingwood mentioned this issue Feb 1, 2018
Closed
@ndellingwood
Copy link
Contributor

Fix in PR #1380 spot checked with test_all_sandia and should be ready for merge.

@ndellingwood ndellingwood mentioned this issue Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 February
Development

No branches or pull requests
4 participants
@ibaned @hcedwar @crtrott @ndellingwood