Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KokkosConcepts SpaceAccessibility function #1092

Closed
mndevec opened this issue Sep 7, 2017 · 0 comments
Closed

KokkosConcepts SpaceAccessibility function #1092

mndevec opened this issue Sep 7, 2017 · 0 comments
Assignees
@hcedwar
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017 October

Comments

@mndevec
Copy link

mndevec commented Sep 7, 2017

Is it possible to move SpaceAccessibility function out of Impl namespace?
This was referenced Sep 7, 2017
Closed
Closed
@hcedwar hcedwar added this to the 2017 September milestone Sep 13, 2017
@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Sep 13, 2017
@hcedwar hcedwar self-assigned this Sep 20, 2017
hcedwar added a commit to hcedwar/kokkos that referenced this issue Sep 20, 2017
@hcedwar
For kokkos#809 and kokkos#1092
ead19d5 
For kokkos#1092: Move SpaceAccessibility meta-function to Kokkos namespace.

For kokkos#809: Always have KOKKOS_MEMORY_ALIGNMENT macro defined,
replace KOKKOS_ALIGN_SIZE with KOKKOS_MEMORY_ALIGNMENT, and
static_assert that it is a power of two.
Rename KOKKOS_ALIGN_PTR macro as KOKKOS_IMPL_ALIGN_PTR.
Remove KOKKOS_ALIGN macro and just use __attribute__((aligned(size))),
this is used in only one soon-to-be-deprecated location.
@hcedwar hcedwar mentioned this issue Sep 20, 2017
Merged
crtrott added a commit that referenced this issue Sep 21, 2017
@crtrott
Merge pull request #1115 from hcedwar/develop
c424595 
For #809 and #1092
@crtrott crtrott closed this as completed Oct 28, 2017
@crtrott crtrott mentioned this issue Oct 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017 October
Development

No branches or pull requests
3 participants
@hcedwar @crtrott @mndevec