Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable construction of unmanaged view using common_view_alloc_prop #1170

Closed
ndellingwood opened this issue Oct 16, 2017 · 1 comment
Closed

Enable construction of unmanaged view using common_view_alloc_prop #1170

ndellingwood opened this issue Oct 16, 2017 · 1 comment
Assignees
@ndellingwood
Labels
Enhancement Improve existing capability; will potentially require voting Feature Request Create new capability; will potentially require voting
Milestone
2017 December

Comments

@ndellingwood
Copy link
Contributor

@mperego would like this enhancement for use-cases in Intrepid2:

He’d like to get a Fad dimension from a View (of Fad type) by using the common_view_alloc_prop while in a kernel/device function. The fad dim would then be used to create an unmanaged view wrapping a pre-allocated workspace.

Currently this does not work (at least in part) because of a lack of KOKKOS_INLINE_FUNCTION attributes in several places and components used by the Kokkos View (and Sacado specializations), for example the common_view_alloc_prop function itself, ViewCtorProp constructors, the view_wrap routine.

@hcedwar @crtrott is there any reason adding KOKKOS_INLINE_FUNCTION to the places I mention above would cause problems, and hence I should not make these changes?
@ndellingwood ndellingwood self-assigned this Oct 16, 2017
@ndellingwood ndellingwood added the Enhancement Improve existing capability; will potentially require voting label Oct 16, 2017
ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Oct 18, 2017
@ndellingwood
View, ViewCtorProp: Address issue kokkos#1170
2bf66d5 
Addresses issue kokkos#1170
Add KOKKOS_INLINE_FUNCTION to necessary functions ( view_wrap,
    common_view_alloc_prop) and constructors to enable construction of
an unmanaged view within a device function using the
common_view_alloc_prop and view_wrap functions.
@ndellingwood ndellingwood mentioned this issue Oct 18, 2017
Merged
@ndellingwood
Copy link
Contributor Author

PR #1176 issued to address this.

@ndellingwood ndellingwood added this to the 2017 December milestone Oct 18, 2017
@ndellingwood ndellingwood added the Feature Request Create new capability; will potentially require voting label Oct 18, 2017
hcedwar added a commit that referenced this issue Oct 19, 2017
@hcedwar
Merge pull request #1176 from ndellingwood/issue-1170
6b39316 
View, ViewCtorProp: Address issue #1170
@hcedwar hcedwar closed this as completed Nov 1, 2017
@crtrott crtrott mentioned this issue Dec 15, 2017
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Enhancement Improve existing capability; will potentially require voting Feature Request Create new capability; will potentially require voting
Projects
None yet
Milestone
2017 December
Development

No branches or pull requests
2 participants
@hcedwar @ndellingwood