Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicView non-power of two value_type #1177

Closed
hcedwar opened this issue Oct 18, 2017 · 1 comment
Closed

DynamicView non-power of two value_type #1177

hcedwar opened this issue Oct 18, 2017 · 1 comment
Assignees
@hcedwar
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2017 October

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Oct 18, 2017

The DynamicView currently assumes, and should not, power of two size value_type.
Add unit test for non-power of two and fix the bug.
@hcedwar hcedwar added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Oct 18, 2017
@hcedwar hcedwar self-assigned this Oct 18, 2017
@hcedwar
Copy link
Contributor Author

hcedwar commented Oct 19, 2017

Upon further evaluation the DynamicView's value_type should always have a power-of-two size for both runtime and memory performance. This requirement (formerly an undocumented assumption) must be documented and asserted at compile time.

hcedwar added a commit that referenced this issue Oct 19, 2017
@hcedwar
Add static_assert to verify DynamicView given power-of-two value_type…
c494cca 
…. Issue #1177
@hcedwar hcedwar added this to the 2017 October milestone Oct 19, 2017
@crtrott crtrott closed this as completed Oct 28, 2017
@crtrott crtrott mentioned this issue Oct 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2017 October
Development

No branches or pull requests
2 participants
@hcedwar @crtrott